-
Notifications
You must be signed in to change notification settings - Fork 804
Migrate from Poetry to uv #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
t41372
wants to merge
3
commits into
getzep:main
Choose a base branch
from
t41372:migrate-to-uv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's done? - A working docker image and build process rewritten to use uv instead of poetry. - This commit fixed (getzep#439) - Updated lock files (for `server`, graph-service): - Updated pyproject.toml that is compatible with uv. - updated Makefile Why? - This is a part of the pull request to migrate from Poetry to UV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to be017fd in 1 minute and 40 seconds. Click for details.
- Reviewed
1424
lines of code in9
files - Skipped
1
files when reviewing. - Skipped posting
17
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. CONTRIBUTING.md:56
- Draft comment:
Updated installation instructions to use uv instead of Poetry. Verify that contributing docs elsewhere mention correct UV usage. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
2. Dockerfile:2
- Draft comment:
Using uv base image and setting performance toggles looks good. Confirm that the chosen uv image tag meets all project requirements. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
3. Dockerfile:14
- Draft comment:
Ensure that copying all source files (pyproject.toml, uv.lock, README.md, and directories) preserves file permissions as expected. - Reason this comment was not posted:
Confidence changes required:20%
<= threshold80%
None
4. Dockerfile:20
- Draft comment:
Creation and activation of the virtual environment using 'uv venv' is appropriate. Validate that subsequent uv pip commands use this venv correctly. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
5. Dockerfile:27
- Draft comment:
Separate installation of graphiti-core (editable) and the FastAPI server package is clear. Confirm dependency resolution order doesn’t introduce conflicts. - Reason this comment was not posted:
Confidence changes required:10%
<= threshold80%
None
6. Makefile:4
- Draft comment:
Variable renaming from POETRY to UV is correctly propagated. Ensure all commands in the workflow are tested with uv. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
7. pyproject.toml:33
- Draft comment:
Dependency groups are now specified under [dependency-groups]. Ensure that the build-system integration with uv is correct despite still relying on poetry-core. - Reason this comment was not posted:
Confidence changes required:40%
<= threshold80%
None
8. server/Makefile:4
- Draft comment:
Server Makefile updates reflect the migration to uv successfully. Confirm that linting and type-checking commands behave as expected. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
9. server/pyproject.toml:28
- Draft comment:
The server project’s pyproject.toml now uses the [project] format. Verify that the use of 'graphiti-core @ ../' correctly resolves the dependency from the local path. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
10. server/pyproject.toml:28
- Draft comment:
As with the core project, the build system still references poetry-core. Confirm this aligns with the uv migration strategy. - Reason this comment was not posted:
Confidence changes required:40%
<= threshold80%
None
11. CONTRIBUTING.md:56
- Draft comment:
Updated install instructions now reference uv instead of Poetry. This is clear and follows the migration. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold80%
This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply acknowledges a change that was made, which violates the rule against making purely informative comments.
12. Dockerfile:1
- Draft comment:
The Dockerfile now uses the uv builder image and uv commands (e.g., 'uv venv', 'uv pip install'). Verify that the uv.lock file is maintained and that the server code path (/app/server/graph_service) matches the expected structure. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold80%
The comment is asking the PR author to verify certain aspects of the Dockerfile changes, which violates the rule against asking the author to confirm or verify intentions. It does not provide a specific suggestion or point out a clear issue with the code. Therefore, it should not be approved.
13. README.md:136
- Draft comment:
Added snippet for 'uv add graphiti-core' is clear. Consider indicating if uv is now the preferred dependency manager and if Poetry instructions will be deprecated to avoid confusion. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold80%
This comment is asking for clarification on the preferred dependency manager, which is not allowed as per the rules. It doesn't provide a specific code suggestion or ask for a test to be written. Therefore, it should be removed.
14. pyproject.toml:55
- Draft comment:
The dependency groups have been updated, but the [build-system] section still uses poetry-core. Confirm whether this is intentional or if the build backend should change with the migration to uv. - Reason this comment was not posted:
Comment was on unchanged code.
15. server/Makefile:15
- Draft comment:
Makefile commands have been updated to use uv (e.g., 'uv sync --group dev', 'uv run pytest'). Ensure that these uv commands work as expected for managing dependencies and running tests. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold80%
This comment is asking the PR author to ensure that theuv
commands work as expected, which violates the rule against asking the author to confirm or ensure behavior. It doesn't provide a specific suggestion or point out a specific issue.
16. Makefile:25
- Draft comment:
There is a trailing whitespace at the end of line 25 (after '--pretty'). Please remove the trailing whitespace to maintain consistency and avoid needless diff noise in future edits. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
17. README.md:196
- Draft comment:
Typographical error: 'OpenAi-compatible' should be 'OpenAI-compatible' for consistency in spelling. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_5Epd0I6v8xB6Mvc9
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the project from Poetry to UV, following the discussion in #420.
Note: I have not updated the GitHub Actions workflows yet, as I’m less familiar with CI/CD pipelines. The current workflows still rely on Poetry, so we’ll need to address that before merging to ensure everything runs smoothly.
✅ What’s been done:
graphiti-core
andgraph-service
to use UV for dependency management.README
andCONTRIBUTING
docs to reflect the switch to UV.🚧 What’s not done:
Important
Migrated project from Poetry to UV for dependency management, updating Dockerfile, Makefile, and documentation, but GitHub Actions workflows still need migration.
graphiti-core
andgraph-service
.pyproject.toml
to use UV's dependency group format.README.md
andCONTRIBUTING.md
to reflect the switch to UV.This description was created by
for be017fd. You can customize this summary. It will automatically update as commits are pushed.